open_source / mqtt-cpp

2 participants

Steven de Ridder started a discussion on the outdated diff

last updated by Peter M. Groen 2022-02-14 14:24:34 UTC

Steven de Ridder started a discussion on the outdated diff

last updated by Steven de Ridder 2022-02-14 13:35:05 UTC

Steven de Ridder started a discussion on the outdated diff

last updated by Steven de Ridder 2022-02-14 13:38:50 UTC

include/mqttsubscriberbase.h 0 → 100644

	13	+ * *
	14	+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR *
	15	+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, *
	16	+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL *
	17	+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER *
	18	+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING *
	19	+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER *
	20	+ * DEALINGS IN THE SOFTWARE. *
	21	+ * ***************************************************************************/
	22	+#pragma once
	23	+
	24	+// std
	25	+#include <memory>
	26	+#include <string>
	27	+
	28	+#include "mqttclient.h"
1		Link here Steven de Ridder @sridder 2022-02-14 13:46:37 UTC missing comment // osdev::components::mqtt Write Preview missing comment // osdev::components::mqtt Edit in fullscreen Comments are parsed with GitLab Flavored Markdown Attach files by dragging & dropping or selecting them. Cancel

78	78	{
79	79	std::cout << "{OK}" << std::endl;
80	80	std::cout << "Connecting to the broker : ";
81		- pPublisher->connect( "localhost", 1883, "", "" );
	81	+ pPublisher->connect( "office.osdev.nl", 1883, "", "" );
2		Link here Steven de Ridder @sridder 2022-02-14 13:24:04 UTC should this contain the osdev broker in an open_source repo? I would leave it at localhost. Write Preview should this contain the osdev broker in an open_source repo? I would leave it at localhost. Edit in fullscreen Comments are parsed with GitLab Flavored Markdown Attach files by dragging & dropping or selecting them. Cancel Link here Peter M. Groen @pgroen 2022-02-14 14:24:34 UTC Good point Write Preview Good point Edit in fullscreen Comments are parsed with GitLab Flavored Markdown Attach files by dragging & dropping or selecting them. Cancel

	64	+ # ${CMAKE_CURRENT_SOURCE_DIR}/compat-c++14.h
	65	+ # ${CMAKE_CURRENT_SOURCE_DIR}/compat-chrono.h
	66	+ # ${CMAKE_CURRENT_SOURCE_DIR}/histogram.h
	67	+ # ${CMAKE_CURRENT_SOURCE_DIR}/histogramprovider.h
	68	+ # ${CMAKE_CURRENT_SOURCE_DIR}/imqttclient.h
	69	+ # ${CMAKE_CURRENT_SOURCE_DIR}/imqttclientimpl.h
	70	+ # ${CMAKE_CURRENT_SOURCE_DIR}/lockguard.h
	71	+ # ${CMAKE_CURRENT_SOURCE_DIR}/macrodefs.h
	72	+ # ${CMAKE_CURRENT_SOURCE_DIR}/measure.h
	73	+ # ${CMAKE_CURRENT_SOURCE_DIR}/metaprogrammingdefs.h
	74	+ # ${CMAKE_CURRENT_SOURCE_DIR}/mqttstream.h
	75	+ # ${CMAKE_CURRENT_SOURCE_DIR}/stringify.h
	76	+ # ${CMAKE_CURRENT_SOURCE_DIR}/stringutils.h
	77	+ # ${CMAKE_CURRENT_SOURCE_DIR}/synchronizedqueue.h
	78	+ # ${CMAKE_CURRENT_SOURCE_DIR}/utils.h
	79	+ # ${CMAKE_CURRENT_SOURCE_DIR}/uriutils.h
1		Link here Steven de Ridder @sridder 2022-02-14 13:35:05 UTC these files are moved to the new include folder, so I assume these commented includes should be removed from the CMakeLists.txt Write Preview these files are moved to the new include folder, so I assume these commented includes should be removed from the CMakeLists.txt Edit in fullscreen Comments are parsed with GitLab Flavored Markdown Attach files by dragging & dropping or selecting them. Cancel

Feat/pgroen/pure virtual public interface